Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build rule file for proper MSVC release build #34

Merged
merged 1 commit into from
Feb 13, 2014
Merged

Fixed build rule file for proper MSVC release build #34

merged 1 commit into from
Feb 13, 2014

Conversation

marynate
Copy link
Contributor

  • Add /ENTRY:mainCRTStartup linker flag for MSVC release build
  • Move /DEBUG linker flag to debug build only

@reduz
Copy link
Member

reduz commented Feb 13, 2014

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

@godotengine
Copy link
Collaborator

ah I see, with this I can delete WinMain on godot_windows.cpp ?

On Wed, Feb 12, 2014 at 11:17 PM, reduz [email protected] wrote:

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-34941834
.

OkamStudio

@punto-
Copy link
Contributor

punto- commented Feb 13, 2014

Is that to get rid of the WinMain entry point? is there any advantage to
using it? (other than deleting WinMain wich already very welcome)

On Wed, Feb 12, 2014 at 11:17 PM, reduz [email protected] wrote:

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-34941834
.

@marynate
Copy link
Contributor Author

Yes, it get rid of WinMain, so one single main entry point to be maintained as debug build while show no console window.
But more important is that without "/ENTRY:mainCRTStartup" flag, MSVC release build won't run properly ( eg, godot.exe -path path_to_game will not startup the game). It might be the bug in windows argument parsing.

godotengine pushed a commit that referenced this pull request Feb 13, 2014
Merge pull request #34 from marynate/master
ca60bae 
Fixed build rule file for proper MSVC release build
@godotengine godotengine merged commit ca60bae into godotengine:master Feb 13, 2014
@draxdeveloper draxdeveloper mentioned this pull request Aug 31, 2015
Closed
@NathanWarden NathanWarden mentioned this pull request Oct 6, 2017
Closed
@kakoeimon kakoeimon mentioned this pull request Dec 18, 2017
Closed
@wolfviking0 wolfviking0 mentioned this pull request May 4, 2018
Closed
@GatoAmarilloBicolor GatoAmarilloBicolor mentioned this pull request Dec 27, 2018
Closed
@noxtrip noxtrip mentioned this pull request Mar 14, 2019
Closed
@JezSonic JezSonic mentioned this pull request Apr 20, 2020
Closed
@davidkbd davidkbd mentioned this pull request Jun 6, 2020
Closed
@Darkheron Darkheron mentioned this pull request Oct 26, 2020
Closed
@ddxt ddxt mentioned this pull request Jun 3, 2022
Closed
@Flynsarmy Flynsarmy mentioned this pull request Oct 12, 2022
Closed
@norrath-hero-cn norrath-hero-cn mentioned this pull request Jan 26, 2023
Closed
lawnjelly added a commit to lawnjelly/godot that referenced this pull request May 14, 2023
@lawnjelly
Merge pull request godotengine#34 from lawnjelly/plus_sync
d8de7a7 
Plus sync
@MileyHollenberg MileyHollenberg mentioned this pull request Jul 27, 2024
Closed
MisterPuma80 pushed a commit to MisterPuma80/just_a_game_engine that referenced this pull request Oct 18, 2024
@Bioblaze
Merge pull request godotengine#34 from blazium-engine/revert-18-edito…
3da8c66 
…r-rebranding-(GUI)

Revert "Editor rebranding (GUI)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marynate @reduz @godotengine @punto-